Re-enable kotlin tests - #1939
Merged
Merged
Conversation
Reverts #1473
Contributor
Author
|
Hmmm...now it's failing, but because there's an even newer version of kotlin. We are going to need to choose a specific version of kotlin based on the version of the CLI. |
aeisenberg
force-pushed
the
aeisenberg/enable-kotlin-tests
branch
4 times, most recently
from
October 13, 2023 22:20
a572e6d to
c5f043e
Compare
Change the `prepare-test` action to conditionally setup kotlin.
aeisenberg
force-pushed
the
aeisenberg/enable-kotlin-tests
branch
from
October 13, 2023 22:25
c5f043e to
fcf7c47
Compare
aeisenberg
marked this pull request as draft
November 14, 2023 18:22
Contributor
Author
|
Converting to draft mode since I won't be able to work on this. If someone else wants to pick it up, please do so. |
Contributor
Author
|
Not going to be able to get to this. |
aeisenberg
force-pushed
the
aeisenberg/enable-kotlin-tests
branch
from
June 14, 2024 20:46
11b4852 to
dd6e97c
Compare
aeisenberg
force-pushed
the
aeisenberg/enable-kotlin-tests
branch
from
June 14, 2024 21:17
dd6e97c to
a449977
Compare
aeisenberg
force-pushed
the
aeisenberg/enable-kotlin-tests
branch
2 times, most recently
from
June 14, 2024 22:19
1682ca4 to
7512620
Compare
aeisenberg
force-pushed
the
aeisenberg/enable-kotlin-tests
branch
from
June 14, 2024 22:27
7512620 to
31a716b
Compare
aeisenberg
marked this pull request as ready for review
June 14, 2024 22:36
Contributor
Author
|
This should now be working properly. The version of kotlin is fixed to 1.8.21. We can consider upgrading the version in the future, or even running against multiple versions if we like. |
angelapwen
approved these changes
Jun 17, 2024
angelapwen
left a comment
angelapwen
left a comment
Contributor
There was a problem hiding this comment.
Thanks for getting back to this!! ✨
This was referenced Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1473